perf: extract vite:resolve internal functions #12522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
approved these changes
Mar 23, 2023
Comment on lines
+465
to
+467
| const isNodeModule = | ||
| nodeModulesInPathRE.test(normalizePath(id)) || | ||
| nodeModulesInPathRE.test(normalizePath(resolved)) |
There was a problem hiding this comment.
Maybe we can improve this part too. We're doing simple node_modules includes check everywhere, not sure why we special case a regex check here. We can simplify this to: id.includes('node_modules') || resolved.includes('node_modules')
There was a problem hiding this comment.
Ah it looks like I asked the same thing last year too 🙈 #9848 (comment)
There was a problem hiding this comment.
haha, and I'll say the same, but this time let's do it in another PR for real 😅
There was a problem hiding this comment.
Checking node_modules alone has worked well so far for us, I don't think we need to be stricter though
patak-dev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract two functions in
vite:resolveresolveIdthat are being created for every call.What is the purpose of this pull request?