perf: replace startsWith with === #12531
Merged
+47
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr use
str[0] === 'x'
instead ofstr.startsWith('x')
for better perf. We can prove that:===
should be faster according tostartsWith
source in theoryperf test
data[0] === 'x'
wins most of the timeI also test the initial
vite dev
startup time five times with this repo before and after this PRIt improves!
Additional context
I guess we can use
str[str.length - 1] === 'x'
rather thanstr.endsWith('x')
too.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).