Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use safeRealpath in getRealpath #12551

Merged
merged 1 commit into from Mar 23, 2023
Merged

perf: use safeRealpath in getRealpath #12551

merged 1 commit into from Mar 23, 2023

Conversation

sapphi-red
Copy link
Member

Description

I only have a Windows machine so I'm not sure if this changes anything.
But I guess safeRealpath works here as well.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red requested a review from bluwy March 23, 2023 11:40
@stackblitz
Copy link

stackblitz bot commented Mar 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red force-pushed the perf/use-safe-realpath-in-get-real-path branch from be505f9 to e651140 Compare March 23, 2023 11:43
@sapphi-red sapphi-red added the performance Performance related enhancement label Mar 23, 2023
@patak-dev patak-dev merged commit cec2320 into vitejs:main Mar 23, 2023
12 checks passed
@sapphi-red sapphi-red deleted the perf/use-safe-realpath-in-get-real-path branch March 23, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy Awaiting requested review from bluwy

Assignees
No one assigned
Labels
performance Performance related enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sapphi-red @patak-dev