perf: use fsp in more cases #12553
Merged
perf: use fsp in more cases #12553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sun0day
reviewed
Mar 24, 2023
packages/vite/src/node/http.ts
Outdated
| cert: readFileIfExists(cert), | ||
| key: readFileIfExists(key), | ||
| pfx: readFileIfExists(pfx), | ||
| ca: await readFileIfExists(ca), |
There was a problem hiding this comment.
Good idea, done at vitejs/vite@de5e611 (#12553). Also simplified the logic.
bluwy
reviewed
Mar 25, 2023
| @@ -1099,7 +1100,7 @@ async function loadConfigFromBundledFile( | |||
| // for cjs, we can register a custom loader via `_require.extensions` | |||
| else { | |||
| const extension = path.extname(fileName) | |||
| const realFileName = fs.realpathSync(fileName) | |||
| const realFileName = await fsp.realpath(fileName) | |||
There was a problem hiding this comment.
Note: The fsp version of realpath uses .native by default, which would cause file read errors on Windows for network drives. But since we're not doing that here, this change should be safe.
There was a problem hiding this comment.
This caused #12923, the async version returns a path with uppercase volume letter C:\... whereas the earlier version returns it lowercase, so the equality check on line 1107 no longer works.
bluwy
approved these changes
Mar 25, 2023
bluwy
added
performance
9 tasks
Closed
7 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use fs/promises to avoid blocking the main thread in more cases. While we are scanning or pre-bundling, we are also processing for example.
What is the purpose of this pull request?