fix: splitFileAndPostfix works as cleanUrl

[patak-dev]

Description

cleanUrl and splitFileAndPostfix where working in different ways.

cleanUrl('/hello#hash?query') -> '/hello'
splitFileAndPostfix('/hello#hash?query') -> '/hello#hash'

This PR makes cleanUrl make them both work in the same way, possibly fixing issues with dependencies having # in their path. The new cleanUrl also avoids the second regex if it isn't needed.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

Looks like cleanUrl is right, first the hash needs to be removed, and then the query. If not new URL calls we do later on won't work correctly (like in injectQuery).

new URL('https://bar.com#foo?hello').hash === '#foo?hello'
new URL('https://bar.com#foo?hello').search === ''

I think the original splitFileAndPostfix having these inverted may not have been intentional . Probably the intention at that point was to remove both the query and the hash.

Later on, this ended up helping with paths like es5-ext/array/#/concat.

[patak-dev]

The PR now makes splitFileAndPostfix work as cleanUrl instead.

[patak-dev]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
astro	❌ failure
histoire	❌ failure
iles	❌ failure
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt	✅ success
previewjs	✅ success
qwik	✅ success
rakkas	✅ success
sveltekit	✅ success
vite-plugin-ssr	✅ success
vite-plugin-react	✅ success
vite-plugin-react-pages	✅ success
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	✅ success
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	✅ success
windicss	✅ success

[patak-dev]

/ecosystem-ci run astro iles

[patak-dev]

/ecosystem-ci run iles

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
iles	❌ failure

[patak-dev]

Marking this as a fix. I think we should do it, but I'm not sure if in 4.3.

[patak-dev]

It looks like the Iles fail isn't related to this PR, it was failing in others too (cc @ElMassimo in case you have some time to check with the current Vite main).

@bluwy if the Astro fail is because of flakiness, I think we could merge this PR in 4.3.

[bluwy]

I'm not sure if it's a fluke since it's a new error I haven't seen before. re-running again

[bluwy]

/ecosystem-ci run astro

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
astro	✅ success

[bluwy]

So I believe this is how the behaviour had changed:

fsPath	original	fs refactor	pr
foo?bar#baz	foo?bar#baz	-	foo?bar#baz
foo#bar?baz	foo#bar?baz	-	foo#bar + ?baz
foo?bar	-	-	-
foo#bar	foo#bar	foo#bar	foo#bar

The fs refactor PR might've caused a regression, so this PR seems to be on the right track, but with only one change for the second case. I think this PR should be fine then 👍

[patak-dev]

I think you are right, looks like the logic the fs refactor wasn't right. I now updated this PR to ignore foo?bar#baz, we don't need to check that one.

fsPath	original	fs refactor	pr
foo?bar#baz	foo?bar#baz	-	-
foo#bar?baz	foo#bar?baz	-	foo#bar + ?baz
foo?bar	-	-	-
foo#bar	foo#bar	foo#bar	foo#bar

[bluwy]

The new handling sounds good to me too 👍 I have one tiny nit, but this is good after that.