perf(moduleGraph): resolve dep urls in parallel #12619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
reviewed
Mar 27, 2023
bluwy
changed the title
sun0day
force-pushed
the
perf/moduleGraphUpdateInfo
branch
from
4946b09
to
7007ad2
Compare
bluwy
reviewed
Mar 28, 2023
bluwy
previously approved these changes
Mar 28, 2023
patak-dev
reviewed
Mar 28, 2023
| ) | ||
| } else { | ||
| imported.importers.add(mod) | ||
| nextImports.add(imported) |
There was a problem hiding this comment.
I think it would be a good idea to keep the nextImports in the same order as before, at least to help with debugging and to make the runs more stable.
We could await for the result of Promise.all and then add that to nextImports in order.
patak-dev
reviewed
Mar 28, 2023
patak-dev
approved these changes
Mar 29, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve deps' URLs in parallel in
ModuleGraph.updateModuleInfo.I tested this pr perf both in sapphi's repo and mine, there will be 10-50ms faster in the startup.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).