Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call buildStart only once when using next port #12624

Merged
merged 1 commit into from Mar 28, 2023

Conversation

sapphi-red
Copy link
Member

Description

This PR is a partial revert of #12593.

Because httpServer.listen will be called multiple times when falling back to another port, buildStart hook was called multiple times. This was making the object-hook playground test failing on my machine (this count was 4).

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release labels Mar 28, 2023
@sapphi-red sapphi-red added this to the 4.3 milestone Mar 28, 2023
@stackblitz
Copy link

stackblitz bot commented Mar 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red changed the title fix: call buildStart only once when using next port fix: call buildStart only once when using next port Mar 28, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This make sense, I wasn't sure why it was needed before.

@bluwy bluwy merged commit e10c6bd into vitejs:main Mar 28, 2023
13 checks passed
@sapphi-red sapphi-red deleted the fix/call-build-start-once branch March 28, 2023 08:27
@dominikg
Copy link
Contributor

this seems to break vite-plugin-svelte tests with hmr (testcase reload after svelte config change). https://github.com/vitejs/vite-ecosystem-ci/actions/runs/4550450699/jobs/8024503923

@dominikg
Copy link
Contributor

dominikg commented Mar 29, 2023

ecosystem-ci bisect output

The first bad commit could be any of:
0f9ad6896ae93f79cc7ef6fbb2fd56047d719245
e10c6bdc757836781a9285ad2a6a3611bb9d6855
We cannot bisect more!
error while bisecting Error: Command failed with exit code 2: git bisect skip
There are only 'skip'ped commits left to test.
The first bad commit could be any of:
0f9ad6896ae93f79cc7ef6fbb2fd56047d719245
e10c6bdc757836781a9285ad2a6a3611bb9d6855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants