Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: await buildStart before server start #12647

Merged

Conversation

sapphi-red
Copy link
Member

Description

#12624 reverted #12593 partially but it was missing this line.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red changed the title fix: await buildStart before server start fix: await buildStart before server start Mar 29, 2023
@sapphi-red
Copy link
Member Author

/ecosystem-ci run vite-plugin-svelte

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Mar 29, 2023

📝 Ran ecosystem CI: Open

suite result
vite-plugin-svelte ❌ failure

@sapphi-red
Copy link
Member Author

Ummm, I thought this would fix the plugin-svelte ecosystem-ci fail.

@patak-dev
Copy link
Member

Interesting, we should still merge this PR though.

@patak-dev patak-dev merged commit 871d353 into vitejs:main Mar 29, 2023
13 checks passed
@sapphi-red sapphi-red deleted the fix/await-buildstart-before-server-start branch March 29, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants