Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import-analysis): escape quotes correctly #12688

Merged
merged 1 commit into from Apr 1, 2023

Conversation

sapphi-red
Copy link
Member

Description

This won't happen normally. This only happens when the import didn't contain single quotes in the specifier and quoted with single quotes and Vite needs to rewrite that to a path including single quotes.
For example, you'll need to place your project inside a path containing ' and change the root somewhere to make Vite replace the path with /@fs/.

fixes #12667
refs #9729

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 1, 2023
@stackblitz
Copy link

stackblitz bot commented Apr 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy merged commit 1638ebd into vitejs:main Apr 1, 2023
12 checks passed
@sapphi-red sapphi-red deleted the fix-escape-quotes-correctly branch April 2, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite generates invalid syntax in dev mode when path to project root includes a single quote
2 participants