Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): asset in iife worker and relative base #12697

Merged
merged 2 commits into from Apr 7, 2023
Merged

fix(worker): asset in iife worker and relative base #12697

merged 2 commits into from Apr 7, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Apr 2, 2023 •
edited

Description

fixes #9879
refs #9381

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: web workers labels Apr 2, 2023
@stackblitz
Copy link

stackblitz bot commented Apr 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red marked this pull request as draft April 2, 2023 08:55
@sapphi-red sapphi-red force-pushed the fix/iife-worker-relative-base-asset branch from cba5dd0 to 2923b11 Compare April 2, 2023 11:47
@sapphi-red sapphi-red marked this pull request as ready for review April 2, 2023 11:47
@patak-dev patak-dev merged commit ddefc06 into vitejs:main Apr 7, 2023
13 checks passed
@sapphi-red sapphi-red deleted the fix/iife-worker-relative-base-asset branch April 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: web workers p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"document" is not defined for xxxx.wasm?url
3 participants
@sapphi-red @bluwy @patak-dev