fix(optimizer): start optimizer after buildStart #12832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patak-dev
approved these changes
Apr 11, 2023
|
Benchmark run for future reference, in case we would like to attempt moving the scanner/optimizer before the server starts again: https://github.com/vitejs/vite-benchmark/actions/runs/4668997365 |
|
Hmm the benchmark shows that this PR is better, so hey maybe that's a win 😄 |
|
233ms better, wat. Could this be a flux @fi3ework? Anyways, hurray! 🥳 |
I'm still thinking about how to make this "E2E" benchmark more stable without consuming too much CI resource and running time 🥹. This could be a flux 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial revert of #12593
As discussed, it's safer to init the optimizer after
buildStartso that plugins are properly initialized before we start invoking the plugin hooks.Additional context
What is the purpose of this pull request?