Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: parallelize await exportsData from depsInfo #12869

Merged
merged 1 commit into from Apr 14, 2023

Conversation

fi3ework
Copy link
Member

Description

As the title described. IIUC, orders of keys in depsInfo does need to be sorted so they could be parallelized.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Apr 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the performance Performance related enhancement label Apr 14, 2023
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@patak-dev
Copy link
Member

Fired a perf run for reference here https://github.com/vitejs/vite-benchmark/actions/runs/4703191145

@patak-dev
Copy link
Member

Perf improvement looks good ~0.5% for the case where there are many deps (https://github.com/vitejs/vite-benchmark/actions/runs/4703191145)

@patak-dev patak-dev merged commit ab3a530 into vitejs:main Apr 14, 2023
12 checks passed
@fi3ework fi3ework deleted the parallelize-exportsData branch April 15, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants