Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose isFileServingAllowed as public utility #12894

Merged
merged 2 commits into from Apr 18, 2023
Merged

Conversation

antfu
Copy link
Member

@antfu antfu commented Apr 18, 2023

Description

This would be beneficial for meta-frameworks to check if some file/url is safe to serve or short-circuit logics on those files. Using the same configuration from Vite.

Namely, for us, we need it on Nuxt to filter out accessing arbitrary files in the FS with our custom middleware. (Potentially the Vitest browser environment a well)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Apr 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev enabled auto-merge (squash) April 18, 2023 11:33
@patak-dev patak-dev merged commit 93e095c into main Apr 18, 2023
18 checks passed
@patak-dev patak-dev deleted the feat/is-fs-allowed branch April 18, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants