Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn pnp considerBuiltins #12903

Merged
merged 1 commit into from Apr 19, 2023
Merged

Conversation

patak-dev
Copy link
Member

Fixes #12888

Description

Regression introduced by #12441

See pnp.resolveToUnqualified docs. By default considerBuiltins is true and this call then fails to resolve buffer and string_decoder which are packages in the project.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Apr 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 18, 2023
@patak-dev
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Apr 18, 2023

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ❌ failure
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt ❌ failure
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
vite-plugin-ssr ❌ failure
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ❌ failure
vite-setup-catalogue ✅ success
vitepress ❌ failure
vitest ✅ success
windicss ✅ success

@patak-dev
Copy link
Member Author

The errors in ecosystem-ci are unrelated to this PR (there is an issue in the latest commit to vite-plugin-vue)

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I tested this PR with the repro of #12888 on Windows.

@sapphi-red sapphi-red added the regression The issue only appears after a new release label Apr 19, 2023
@sapphi-red sapphi-red added this to the 4.3 milestone Apr 19, 2023
@patak-dev patak-dev merged commit a0e10d5 into main Apr 19, 2023
18 checks passed
@patak-dev patak-dev deleted the fix/yarn-pnp-consider-builtins branch April 19, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression on vite 4.3 build when resolving packages
3 participants