fix(build): make output warning message clearer

[btea]

Description

before

after

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[ArnaudBarre]

Related and (maybe fixes) #11207

I don't know the implication but maybe we should clear the line too before calling userOnWarn

[danieldeandradelopes]

Nice.

[bluwy]

This could be a bit risky. Sometimes logs appear during transformation, and the logs could give a hint as to which file causes the log (though with an uglier output). This PR would clear the "current transforming file" and loses the information.

[ArnaudBarre]

Actually this is the opposite because we throttle the displayed file: https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/reporter.ts#L63
So this can avoid displaying the name of an unrelated file before the warning.
But a good point is that we should gives better hints on the module that triggered the warning. Don't know if this should be in the same PR or not

[bluwy]

Interesting. I'm not sure why it's being throttled, but I definitely had experienced the file name showed to be accurate that helped me in debugging things.

[ArnaudBarre]

Printing to terminal can be slow, famous bug report: npm/npm#11283

[patak-dev]

Added it to the 4.4 milestone, I think we could merge this one in the next beta to get some folks trying it out.

[bluwy]

I think it would still be good to make this work generically instead of only for this.warn/this.error, since a stray console.log from a plugin would still mess up the logs.

I'd also prefer if we don't clear the current line (even if it could be wrong) since it could be helpful at times.

Perhaps during the transforming log phase, we could capture process.stdout.write and make sure all writes precede with logging the last "transforming id" + a new line + the warning/error logs?

[ArnaudBarre]

I'm in for monkey patching the console.log or process.write but this can have unexpected interactions with people building on top of it. How does Astro and Nuxt use (or not) the builtin Vite reporter?

The fact that we could log the current transforming file before the log is a big win for me (but does that even possible? Rollup doesn't do parallel execution?)

[patak-dev]

@bluwy @ArnaudBarre should we move this PR to the Vite 5 milestone?

[ArnaudBarre]

Completely changed my mind: I think we should go with monkey patching directly.
For me it's safe for 4.4, but can be discussed

[bluwy]

For me, I think it's also fine to merge this PR as a stop gap, and work on a more complete solution later.

[bluwy]

Maybe we can simplify this like

vite/packages/vite/src/node/plugins/reporter.ts

Lines 280 to 283 in 1e299cc

	function clearLine() {
	process.stdout.clearLine(0)
	process.stdout.cursorTo(0)
	}

[btea]

Done.