Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: build time message setting color #12940

Merged
merged 1 commit into from Apr 23, 2023
Merged

chore: build time message setting color #12940

merged 1 commit into from Apr 23, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Apr 21, 2023

Description

before
a

after
b

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Apr 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like this better!

@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Apr 21, 2023
danieldeandradelopes
danieldeandradelopes approved these changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@danieldeandradelopes danieldeandradelopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is an best return

bluwy
bluwy approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a strong opinion about this, but fine by me too.

@patak-dev patak-dev merged commit ada7cd5 into vitejs:main Apr 23, 2023
13 checks passed
@btea btea deleted the chore/build-message-color branch April 23, 2023 05:43
@sync-by-unito sync-by-unito bot mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@danieldeandradelopes danieldeandradelopes danieldeandradelopes approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@btea @patak-dev @danieldeandradelopes @bluwy