Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): import @babel/preset-env #12961

Merged
merged 2 commits into from
May 2, 2023

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Apr 23, 2023

Description

@vitejs/plugin-legacy specifies that Babel should use @babel/preset-env but doesn't specify where it should resolve it from so Babel defaults to process.cwd(), usually the current project, making it rely on hoisting.

This PR fixes that by dynamically importing @babel/preset-env and passing the result to Babel.

Alternatively one could use the Babel option cwd to make it resolve relative to @vitejs/plugin-legacy or use require.resolve to give Babel an absolute path to the preset.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Apr 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added plugin: legacy p3-minor-bug An edge case that only affects very specific usage (priority) labels May 2, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sapphi-red sapphi-red merged commit d53c650 into vitejs:main May 2, 2023
12 checks passed
@merceyz merceyz deleted the merceyz/fix/legacy-hoisting branch May 2, 2023 12:28
@shalldie
Copy link

shalldie commented May 9, 2023

Release a new version?
Now using pnpm to build will report an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants