Module * has been externalized warnings

[edikdeisling]

Describe the bug

Starting from Vite 4.3 during build there are warnings about externalization.

Module "os" has been externalized for browser compatibility, imported by "/home/projects/vitejs-vite-wogwpc/node_modules/.pnpm/jsdom@20.0.3/node_modules/jsdom/lib/jsdom/living/navigator/NavigatorConcurrentHardware-impl.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] Module "net" has been externalized for browser compatibility, imported by "/home/projects/vitejs-vite-wogwpc/node_modules/.pnpm/http-proxy-agent@5.0.0/node_modules/http-proxy-agent/dist/agent.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] Module "tls" has been externalized for browser compatibility, imported by "/home/projects/vitejs-vite-wogwpc/node_modules/.pnpm/http-proxy-agent@5.0.0/node_modules/http-proxy-agent/dist/agent.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] Module "url" has been externalized for browser compatibility, imported by "/home/projects/vitejs-vite-wogwpc/node_modules/.pnpm/http-proxy-agent@5.0.0/node_modules/http-proxy-agent/dist/agent.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] Module "net" has been externalized for browser compatibility, imported by "/home/projects/vitejs-vite-wogwpc/node_modules/.pnpm/https-proxy-agent@5.0.1/node_modules/https-proxy-agent/dist/agent.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] Module "tls" has been externalized for browser compatibility, imported by "/home/projects/vitejs-vite-wogwpc/node_modules/.pnpm/https-proxy-agent@5.0.1/node_modules/https-proxy-agent/dist/agent.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] Module "url" has been externalized for browser compatibility, imported by "/home/projects/vitejs-vite-wogwpc/node_modules/.pnpm/https-proxy-agent@5.0.1/node_modules/https-proxy-agent/dist/agent.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] Module "assert" has been externalized for browser compatibility, imported by "/home/projects/vitejs-vite-wogwpc/node_modules/.pnpm/https-proxy-agent@5.0.1/node_modules/https-proxy-agent/dist/agent.js". See http://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.

Seems that this is related to #12888. But that issue is closed but warnings still present

Reproduction

https://stackblitz.com/edit/vitejs-vite-wogwpc

Steps to reproduce

Open stackblitz and run pnpm build

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    vite: 4.3.1 => 4.3.1

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• vitejs-vite-wogwpc (Open reproduction)

[chaxus]

The reason may be that vite cannot build the node module，The source code in packages/vite/src/node/plugins/resolve.ts is as follows：

if (id.startsWith(browserExternalId)) {
if (isProduction) {
return export default {}

It turns the node module into an empty module
It is also stated in the documentation provided,(https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility).

This is because Vite does not automatically polyfill Node.js modules.
We recommend avoiding Node.js modules for browser code to reduce the bundle size, although you can add polyfills manually. If the module is imported from a third-party library (that's meant to be used in the browser), it's advised to report the issue to the respective library.

[edikdeisling]

But there are no node.js modules in the client bundle. Here is the code

const win = import.meta.env.SSR ? new (await import('jsdom')).JSDOM('').window : window;

jsdom isn't included in the final client bundle.

[sapphi-red]

Duplicate of #5676