feat: optimize deps option to turn off auto discovery #13000
Merged
+124
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edit: I ended up renaming it to
noDiscovery
.Adds a new experimental boolean option
optimizeDeps.noDiscovery
, defaulting totrue
@sheremet-va is exploring replacing Vitest
deps.inline
feature with Vite's deps optimization. To make this work, they need auto-discovery of dependencies to be turned off. They would like to have full control of what dependencies get optimized usingoptimizeDeps.include
. We should also merge #12414 to add glob support tooptimizeDeps.include
Some other options we evaluated in this gist.
Edit: scratch the next paragraph, as it simplified the logic to rename at the end.
@bluwy also proposed we use
noDiscovery
instead ofautoDiscovery
so we can have the option be false by default. I think this is a good idea in general but in this case, I find it a bit more confusing. @bluwy I checked and we have a lot of boolean options that default to true.preTransformRequests
for example. Let's see what others think.It is experimental because @sheremet-va will need to play with this and we may end up changing this feature later. I think we could move forward so they can check what we are missing.
What is the purpose of this pull request?