Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): track for statements as block scope #13021

Merged
merged 1 commit into from Apr 27, 2023
Merged

fix(ssr): track for statements as block scope #13021

merged 1 commit into from Apr 27, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 27, 2023

Description

fix #13012

variable declarations inside for statements should scoped to nearest For(?:In|Of)?Statement instead of BlockStatement

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p4-important Violate documented behavior or significantly improves performance (priority) feat: ssr labels Apr 27, 2023
@stackblitz
Copy link

stackblitz bot commented Apr 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 2f8502f into main Apr 27, 2023
13 checks passed
@patak-dev patak-dev deleted the ssr-scope-for branch April 27, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssrTransform incorrectly transforms references in "for" block
2 participants