Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): should respect hmr port when middlewareMode=false #13040

Merged
merged 1 commit into from May 1, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Apr 28, 2023

Description

fix #12964
refs #12734

Additional context

There are server init & restart steps below:

(1) create new vite-server instance
(2) new vite-server listening
(3) close old vite-server

(4) create new ws-server instance
(5) new ws-server listening
(6) close old ws-server

After this PR and #12734, (vite-server & ws-server)'s init and restart flows become:

middlewareMode=false, sharing vite-server

  • init flow: (4) (1) (2)
  • restart flow: (4) (1) (3) (2)

middlewareMode=false, splitting vite-server & ws-server

  • init flow: (4) (1) (5) (2)
  • restart flow: (4) (1) (6) (3) (5) (2)

middlewareMode=true

  • init flow: (4) (5) (1)
  • restart flow: (4) (1) (6) (5)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Apr 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release labels May 1, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev merged commit 1ee0014 into vitejs:main May 1, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR port config not respected
3 participants