fix(mergeConfig): don't accept callback config #13135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mergeConfig function doesn't work with config in callback form. To make the error more transparent added both a runtime and type checks.
Minhir
changed the title
patak-dev
approved these changes
May 10, 2023
patak-dev
added
the
p3-minor-bug
bluwy
approved these changes
May 29, 2023
sodatea
added a commit
to sodatea/vite
that referenced
this pull request
Jul 11, 2023
Fixes compatibility with `mergeConfig`, as reported in vuejs/create-vue#313 Before the change, `defineConfig` would return `UserConfigExport`, which is a union type. This would cause `mergeConfig` to fail, as it doesn't accept the `UserConfigFn` type in the union. (vitejs#13135) After the change, `defineConfig` returns the same type that it receives, so it would exclude `UserConfigFn` from the return type whenever possible.
9 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mergeConfigfunction doesn't work with config in callback form. To make the error more transparent added both a runtime and type checks. More info #12977Additional context
It's also possible to solve it by auto calling callbacks.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).