Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional expression in dyanmic import's string literal causes error [plugin:vite:asset-import-meta-url] Unterminated template literal #13205

Closed
7 tasks done
daolanfler opened this issue May 15, 2023 · 2 comments
Labels
p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release

Comments

@daolanfler
Copy link

Describe the bug

when conditional expression exists in new URL 's string literal, dev server & build breaks, with this error message [plugin:vite:asset-import-meta-url] Unterminated template literal (1:11)

Reproduction

https://stackblitz.com/edit/vitejs-vite-c6quvn?file=main.js

Steps to reproduce

vite 4.3.1 works fine, 4.3.5 breaks

const bool = false

// const logo = new URL(`./${bool ? `javascript` : "javascript"}.svg`, import.meta.url).href; // works 
const logo = new URL(`./${bool ? "javascript" : "javascript"}.svg`, import.meta.url).href; // doesn't work

toggle comments in above to see the error

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    vite: ^4.3.5 => 4.3.5

Used Package Manager

npm

Logs

No response

Validations

@stackblitz
Copy link

stackblitz bot commented May 15, 2023

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@sapphi-red
Copy link
Member

fixed by #13121

@sapphi-red sapphi-red added p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release labels May 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release
Projects
None yet
Development

No branches or pull requests

2 participants