Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): skip updateCjsSsrExternals if legacy flag disabled #13230

Merged
merged 1 commit into from May 17, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 17, 2023

Description

The updateCjsSsrExternals function updates server._ssrExternals that's only used here:

if (config.legacy?.buildSsrCjsExternalHeuristics) {
if (
cjsShouldExternalizeForSSR(specifier, server._ssrExternals)
) {
return
}

Since that code only runs on config.legacy?.buildSsrCjsExternalHeuristics: true, we can also add the same guard for updateCjsSsrExternals

Additional context

cc @delucis who found this. It was logging the ... doesn't appear to be written in CJS ... warning unnecessarily.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) feat: ssr labels May 17, 2023
@stackblitz
Copy link

stackblitz bot commented May 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting we missed this one for so long

@patak-dev patak-dev merged commit 13fc345 into main May 17, 2023
13 checks passed
@patak-dev patak-dev deleted the ssr-skip-ssr-external branch May 17, 2023 10:27
@ASISBusiness

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants