Env HTML replacement does not remove double quotes from variables defined in config.define

[yannbriancon]

Describe the bug

I am using the env HTML replacement feature to replace a variable in the HTML from an env value defined in vite config.

When stringifying this variable in the vite config, as recommended in the doc, the replacement is wrapped in double quotes.

When not stringifying it, it shows correctly but the js code breaks with the error env.mjs:16 Uncaught SyntaxError: Unexpected identifier 'Title'.

I traced the issue back to the PR #12202 where we do not parse the config define values even though they have to be stringified (line 958)

Reproduction

https://stackblitz.com/edit/vitejs-vite-cbisjp?file=vite.config.js

Steps to reproduce

Add a vite config with a variable:

/* eslint-disable import/no-extraneous-dependencies */
import { defineConfig } from 'vite';

export default ({ mode }) => {
  return defineConfig({
    define: {
      'import.meta.env.TITLE': JSON.stringify('My Title'),
    },
  });
};

Add a replacement pattern in the index.html:

    <title>%TITLE%</title>

Run npm install & npm run dev

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    vite: ^4.3.9 => 4.3.9 

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• vitejs-vite-cbisjp (Open reproduction)