New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove deprecated config.server.base #13482
Conversation
Run & review this pull request in StackBlitz Codeflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never noticed there's this option before. Looks like a good change to me and doesn't seem to break things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the changes of #7289. It seems the PR added server.base
to the types and the docs, but the PR didn't use that anywhere.
Description
I randomly found
server.base
(https://vitejs.dev/config/server-options.html#server-base), but it seems like it is not being used anymore. The code was introduced in this pull request (before vite2 was released), but it appears to have not been invoked after a long period of code iteration. The documentation was introduced in this pull request. I suppose the rootbase
config has supersededserver.base
now.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).