Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: esm detection with export const { A, B } pattern #13483

Merged
merged 1 commit into from Jun 11, 2023
Merged

fix: esm detection with export const { A, B } pattern #13483

merged 1 commit into from Jun 11, 2023

Conversation

alex-kinokon
Copy link
Contributor

Description

Update es-module-lexer. See guybedford/es-module-lexer#153.

Additional context

vite interprets the ESM build of vscode-uri as a CJS dependency and rewrites it to a default import. Since vscode-uri has no default export, it fails in browswer.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jun 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@alex-kinokon alex-kinokon changed the title Fix: ESM detection with export const { A, B } pattern fix: ESM detection with export const { A, B } pattern Jun 10, 2023
@alex-kinokon alex-kinokon changed the title fix: ESM detection with export const { A, B } pattern fix: esm detection with export const { A, B } pattern Jun 11, 2023
@bluwy bluwy merged commit ea1bcc9 into vitejs:main Jun 11, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants