Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(optimizer): include exports for css modules #13519

Merged
merged 1 commit into from Jun 14, 2023
Merged

fix(optimizer): include exports for css modules #13519

merged 1 commit into from Jun 14, 2023

Conversation

sapphi-red
Copy link
Member

Description

refs #12343
fixes #13298

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release feat: deps optimizer Esbuild Dependencies Optimization labels Jun 14, 2023
@stackblitz
Copy link

stackblitz bot commented Jun 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 1fd9919 into vitejs:main Jun 14, 2023
13 checks passed
@Jinjiang Jinjiang mentioned this pull request Jun 14, 2023
Closed
@sapphi-red sapphi-red deleted the fix/optimizer-include-exports-for-css-modules branch June 14, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: deps optimizer Esbuild Dependencies Optimization p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to require (in cjs) CSS modules from an npm package
2 participants
@sapphi-red @patak-dev