Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(proxy): forward SSE close event #13578

Merged
merged 1 commit into from Jun 21, 2023
Merged

fix(proxy): forward SSE close event #13578

merged 1 commit into from Jun 21, 2023

Conversation

sapphi-red
Copy link
Member

Description

See #13522 for more details.

fixes #13522

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jun 21, 2023
@stackblitz
Copy link

stackblitz bot commented Jun 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev enabled auto-merge (squash) June 21, 2023 08:08
@patak-dev patak-dev merged commit 4afbccb into vitejs:main Jun 21, 2023
13 checks passed
@sapphi-red sapphi-red deleted the fix/proxy-sse-close branch June 21, 2023 08:16
xinxinhe1810 pushed a commit to xinxinhe1810/vite that referenced this pull request Jul 4, 2023
@sapphi-red @xinxinhe1810
fix(proxy): forward SSE close event (vitejs#13578)
6ed6701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSE close event is not being forwarded to the server when using Vite as Reverse Proxy
2 participants
@sapphi-red @patak-dev