fix(build): style insert order for UMD builds (fix #13668) #13669
+9
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13668
The previous fix in #13266 can break the insertion order for UMD builds when a dependency containing the string
execute:
is added. This updates the logic to only check forexecute:
whenSystem.register
is found, which should be a more robust way to find the insertion point.TLDR
System.register
calls will insert the CSS in theexecute
functionAdditional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).