fix: avoid early error when server is closed in ssr #13787
Merged
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bjorn Lu <34116392+bluwy@users.noreply.github.com>
|
|
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
bluwy
approved these changes
Jul 11, 2023
| @@ -57,6 +57,7 @@ export async function createServer( | |||
| res.status(200).set({ 'Content-Type': 'text/html' }).end(html) | |||
| } catch (e) { | |||
| vite && vite.ssrFixStacktrace(e) | |||
| if (isTest) throw e | |||
There was a problem hiding this comment.
My test could be flaky as I haven't figured out some case where there's actually unexpected but harmless errors. I'm ok with leaving this out in case it makes our CI unstable 🤔
There was a problem hiding this comment.
CI looks good for now. If we see it starts to bring issues we can remove it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13735
Fixes #13786
Closes #13767
Description
Throwing an error during SSR would force the users to handle it on every call to
ssrLoadModule. What is safer long term is something we should discuss for Vite 5. At least for 4.4 (and I'm leaning towards this approach for 5 too), it is better to avoid the error during SSR. The only reason it was added was to speed up server restart. During SSR, the requests should be fast enough.What is the purpose of this pull request?