Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error logged to console when using manualChunkSplitting and function is used. #13797

Closed
7 tasks done
jafin opened this issue Jul 12, 2023 · 1 comment · Fixed by #13798
Closed
7 tasks done

Error logged to console when using manualChunkSplitting and function is used. #13797

jafin opened this issue Jul 12, 2023 · 1 comment · Fixed by #13798
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@jafin
Copy link
Contributor

jafin commented Jul 12, 2023

Describe the bug

Setup

When you configure vite with splitVendorChunkPlugin()
and configure rollupOptions output manualChunks with a function.

 build: {
        rollupOptions: {
            output: {
                manualChunks: manualChunksFn,
            },
        },
}

function manualChunksFn(id: string) {
// chunklogic
}

Expected:

No console warning about using a function for manualChunks

Actual

Warning logged to console

"(!) the `splitVendorChunk` plugin doesn't have any effect when using the object form of `build.rollupOptions.manualChunks`. Consider using the function form instead.",

This was introduced via #13431
And I believe it just needs an else around the warning to correct.

Reproduction

https://stackblitz.com/edit/vitejs-vite-2epesn?file=vite.config.ts

Steps to reproduce

run npm run build
note output in console logs

docs(chunkSplitting): add manualChunks object form syntax warning when it is used with the splitVendorChunk plugin #13431

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.20.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.6.3 - /usr/local/bin/pnpm
  npmPackages:
    vite: ^4.4.2 => 4.4.3

Used Package Manager

npm

Logs

No response

Validations

@stackblitz
Copy link

stackblitz bot commented Jul 12, 2023

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

jafin added a commit to jafin/vite that referenced this issue Jul 12, 2023
jafin added a commit to jafin/vite that referenced this issue Jul 12, 2023
@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels Jul 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants