perf: use Intl.DateTimeFormatter instead of toLocaleTimeString #13951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
approved these changes
Jul 25, 2023
btea
reviewed
Jul 26, 2023
| @@ -77,7 +82,7 @@ export function createLogger( | |||
| : type === 'warn' | |||
| ? colors.yellow(colors.bold(prefix)) | |||
| : colors.red(colors.bold(prefix)) | |||
| return `${colors.dim(new Date().toLocaleTimeString())} ${tag} ${msg}` | |||
| return `${colors.dim(timeFormatter.format(new Date()))} ${tag} ${msg}` | |||
There was a problem hiding this comment.
It seems that new Date() can be omitted. 🤔
There was a problem hiding this comment.
It looks like that is the case, docs are not clear on MDN https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/format. Maybe better to leave it explicit?
There was a problem hiding this comment.
Yes, I didn't find the documentation clearly stating whether it is optional or not. Only the ts hint is optional, as you said, it should be better to keep it as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #13949. This seems to be the only place left where we are using
toLocaledirectly.What is the purpose of this pull request?