Configuring the ignoreAnnotations parameter is invalid

[aegorx]

Describe the bug

esbuild: {
ignoreAnnotations: true
}

This will cause the comments for vue3 to be removed, Affect normal logic.
E.g. /* STABLE / / TEXT */

vite/packages/vite/src/node/optimizer/index.ts

Line 809 in 9d7d45e

ignoreAnnotations: !isBuild,

Reproduction

Steps to reproduce

No response

System Info

-

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bluwy]

Is this for optimize in build only? Looks like it's added in #8358 but I don't have the full context.

It would also be great if you can provide a repro here.

[sapphi-red]

esbuild strips all comments except /* @__PURE__ */ or /* #__PURE__ */. --ignore-annotations only changes the behavior for these pure comments.
repro: https://esbuild.github.io/try/#dAAwLjE5LjMAAC8vIGNvbW1lbnQKY29uc3QgZm9vID0gJ2ZvbycKCi8qIGNvbW1lbnQgKi8KY29uc3QgYmFyID0gJ2JhcicKCmNvbnN0IGJheiA9IC8qIEBfX1BVUkVfXyAqLygoKSA9PiAnJykoKQo

Removing pure comments won't cause problems other than not being tree-shaked.