Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement AsyncDisposable #14648

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Oct 16, 2023

Description

implement AsyncDisposable interface for supporting using syntax

Extracted Symbol.asyncDispose to a constant for support of Babel downgrading Example

Example

import { createServer } from 'vite'
await using server = await createServer()

Additional context

TS docs


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 16, 2023
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 2facc41: Open

suite result latest scheduled
analogjs success success
astro success failure
histoire success success
ladle success success
laravel failure failure
marko success failure
nuxt success failure
nx failure failure
previewjs success failure
qwik failure failure
rakkas success success
sveltekit failure failure
unocss success success
vike success success
vite-plugin-pwa success success
vite-plugin-react success success
vite-plugin-react-pages success success
vite-plugin-react-swc failure failure
vite-plugin-svelte success success
vite-plugin-vue success success
vite-setup-catalogue success success
vitepress success success
vitest failure failure

@patak-dev patak-dev merged commit 385d580 into vitejs:main Nov 1, 2023
10 checks passed
@sxzz sxzz deleted the feat/AsyncDisposable branch November 2, 2023 02:49
bluwy added a commit that referenced this pull request Nov 8, 2023
bluwy added a commit that referenced this pull request Nov 8, 2023
@patak-dev
Copy link
Member

@sxzz we're reverting this PR for now, see the explanation at #14908. We still think this is a good change, but will be adding the feature later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants