Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove https flag #14681

Merged
merged 3 commits into from
Oct 18, 2023
Merged

refactor!: remove https flag #14681

merged 3 commits into from
Oct 18, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 18, 2023 •
edited

Description

#14621 (comment)

fix #10058

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Oct 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red requested a review from bluwy October 18, 2023 08:38
@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) breaking change labels Oct 18, 2023
@sapphi-red sapphi-red added this to the 5.0 milestone Oct 18, 2023
@sapphi-red sapphi-red marked this pull request as ready for review October 18, 2023 08:51
bluwy
bluwy reviewed Oct 18, 2023
View reviewed changes
docs/guide/migration.md Outdated Show resolved Hide resolved
patak-dev
patak-dev previously approved these changes Oct 18, 2023
View reviewed changes
@sapphi-red @bluwy
docs: update
56d9fc7 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@patak-dev patak-dev merged commit 5b65bfd into vitejs:main Oct 18, 2023
10 checks passed
@sapphi-red sapphi-red deleted the refactor/remove-https-flag branch October 19, 2023 05:48
@bluwy bluwy mentioned this pull request Oct 22, 2023
Closed
@sapphi-red sapphi-red mentioned this pull request Oct 31, 2023
Merged
9 tasks
@btea btea mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev left review comments

Assignees
No one assigned
Labels
breaking change p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

ERR_SSL_VERSION_OR_CIPHER_MISMATCH when both --https and server.https provided
3 participants
@sapphi-red @patak-dev @bluwy