Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolve)!: remove special .mjs handling #14723

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(resolve)!: remove special .mjs handling #14723

merged 1 commit into from
Oct 23, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 22, 2023

Description

fix #14404

When an "exports" field maps to a .mjs file, continue using that file and don't try to resolve the "browser" or "module" fields.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added breaking change p3-significant High priority enhancement (priority) labels Oct 22, 2023
@stackblitz
Copy link

stackblitz bot commented Oct 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy
Copy link
Member Author

bluwy commented Oct 23, 2023

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 3155e3a: Open

suite result latest scheduled
analogjs success success
astro success success
histoire success success
ladle success success
laravel failure failure
marko failure failure
nuxt success success
nx failure failure
previewjs success success
qwik success success
rakkas success success
sveltekit failure failure
unocss success success
vike success failure
vite-plugin-pwa failure failure
vite-plugin-react success success
vite-plugin-react-pages success success
vite-plugin-react-swc success success
vite-plugin-svelte success success
vite-plugin-vue success success
vite-setup-catalogue success success
vitepress success success
vitest success failure

@ArnaudBarre
Copy link
Member

I can't say I understand all the consequences, but less code to better match the spec, I'm all in

@bluwy bluwy merged commit 2141d31 into main Oct 23, 2023
10 checks passed
@bluwy bluwy deleted the unhandle-mjs branch October 23, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change p3-significant High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to whitelist certain packages as "can use the exports map directly"
3 participants