Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(optimizedDeps): remove unused return #14773

Merged
merged 1 commit into from
Nov 3, 2023
Merged

chore(optimizedDeps): remove unused return #14773

merged 1 commit into from
Nov 3, 2023

Conversation

Simon-He95
Copy link
Contributor

Description

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Oct 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Simon-He95
Copy link
Contributor Author

Hi, @patak-dev
What do you think? This return will never come

bluwy
bluwy approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if there's no type errors. It was added before as TypeScript had trouble analyzing it.

@bluwy bluwy changed the title chore(optimizedDep): remove useless code chore(optimizedDeps): remove unused return Nov 3, 2023
@bluwy bluwy merged commit 9d744dd into vitejs:main Nov 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Simon-He95 @bluwy