Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(define): create simple regex for checks #14788

Merged
merged 2 commits into from
Oct 31, 2023
Merged

perf(define): create simple regex for checks #14788

merged 2 commits into from
Oct 31, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 28, 2023

Description

An optimization I intentionally left out (so it's easier to review) in #11151 is to optimize the created regex. Since we're not doing any replacement anymore, we don't need a complex regex for correctness.

We only need a simple regex to check the chances of replacing, and through some quick tests, I found the complex regex vs this simple regex can bring up to 6x faster regex.test() calls (~200ms vs ~30ms)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) performance Performance related enhancement labels Oct 28, 2023
@stackblitz
Copy link

stackblitz bot commented Oct 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev previously approved these changes Oct 30, 2023
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think you can merge after fixing the conflicts

@bluwy bluwy merged commit bd15537 into main Oct 31, 2023
10 checks passed
@bluwy bluwy deleted the define-quick-check branch October 31, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority) performance Performance related enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants