feat: expose parseAst and parseAstAsync from rollup #14833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sheremet-va
commented
Oct 31, 2023
| @@ -80,13 +81,14 @@ function patchTypes(): Plugin { | |||
| }, | |||
| renderChunk(code, chunk) { | |||
| // Validate that chunk imports do not import dev deps | |||
| const deps = new Set(Object.keys(pkg.dependencies)) | |||
| const deps = Object.keys(pkg.dependencies) | |||
There was a problem hiding this comment.
It literally has 3 strings, so performance should not be a problem.
patak-dev
added
the
p3-downstream-blocker
sapphi-red
approved these changes
Nov 1, 2023
bluwy
approved these changes
Nov 1, 2023
6 tasks
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes
parseAstandparseAstAsyncmethods from rollup for an easy access to AST-parsing APIs.To allow export of
rollup/parseAst, we would have to require"moduleResolution"to benode16or higher (because this type is specified inexportsfield, which is not supported innodemodule resolution - https://www.typescriptlang.org/docs/handbook/modules/theory.html#module-resolution-is-host-defined ifskipLibCheckis disabled (although as far as I know, Vite already fails with esbuild'sWebAssemblyglobal usage). But this goes in line with node versions that Vite supports.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).