Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct publicDir in ERR_LOAD_PUBLIC_URL #14847

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

appsforartists
Copy link
Contributor

@appsforartists appsforartists commented Nov 2, 2023

Description

Failed to load url /config.js (resolved id: /config.js). This file is in /public and will be copied 
as-is during build without going through the plugin transforms, and therefore should not be 
imported from source code. It can only be referenced via HTML tags.

had a hardcoded value for /public. This introspects the correct value from config to improve the error message.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
    • There don't seem to be any tests for the error message, and I don't know the repo well enough to make one.

Copy link

stackblitz bot commented Nov 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 2, 2023
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@bluwy bluwy changed the title fix(dev): use correct publicDir in ERR_LOAD_PUBLIC_URL fix: use correct publicDir in ERR_LOAD_PUBLIC_URL Nov 2, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluwy bluwy merged commit 66caef3 into vitejs:main Nov 2, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants