Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "fix: don't add ?import for @vite-ignoreed import (#14851)" #14866

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 3, 2023

Description

This PR reverts #14851.

See #14851 (comment)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Nov 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed internally and agree with a revert for now as the user could want either behaviour, and the previous PR would leak the internal ?import requirement. We could probably re-think how we handle ignored imports in the future.

@patak-dev patak-dev merged commit 6516607 into vitejs:main Nov 3, 2023
10 of 11 checks passed
@sapphi-red sapphi-red deleted the chore/revert-14851 branch November 3, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants