Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(legacy): clarify that csp hashes could change between minors #15057

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

sapphi-red
Copy link
Member

Description

#15021 (comment)

Additional context

Should we mention that pinning the version isn't needed if you are getting the value from import { cspHashes } from '@vitejs/plugin-legacy'?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added documentation Improvements or additions to documentation plugin: legacy labels Nov 21, 2023
@patak-dev
Copy link
Member

Should we mention that pinning the version isn't needed if you are getting the value from import { cspHashes } from '@vitejs/plugin-legacy'?

This sounds like a good idea to me 👍🏼

@sapphi-red
Copy link
Member Author

Tried to include that pinning is not necessary when using cspHashes. I'm not sure if the text is clear.

@patak-dev
Copy link
Member

This reads very well, and it is a good justification as to why we don't consider the changes in the hashes a breaking change

@patak-dev patak-dev merged commit cd35330 into vitejs:main Nov 21, 2023
10 checks passed
@sapphi-red sapphi-red deleted the docs-legacy-csp-minor branch November 21, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants