Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unneccessary eslint-disable-next-line regexp/no-unused-capturing-group #15247

Merged
merged 1 commit into from Dec 5, 2023
Merged

chore: remove unneccessary eslint-disable-next-line regexp/no-unused-capturing-group #15247

merged 1 commit into from Dec 5, 2023

Conversation

sapphi-red
Copy link
Member

Description

The bug (ota-meshi/eslint-plugin-regexp#675) is now fixed

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Dec 5, 2023
@stackblitz StackBlitz
Copy link

stackblitz bot commented Dec 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red enabled auto-merge (squash) December 5, 2023 12:39
@sapphi-red sapphi-red merged commit 35a5bcf into vitejs:main Dec 5, 2023
10 checks passed
@sapphi-red sapphi-red deleted the chore/remove-eslint-disable-regexp-no-unused-capturing-group branch December 5, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sapphi-red @patak-dev