Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress terser warning if minify disabled #15275

Merged
merged 1 commit into from Dec 7, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 7, 2023

Description

fix withastro/astro#9341

Astro disables minification is SSR explicitly, but the user could still pass build.terserOptions as they configure it for the client build. This PR only warns about the terser options if minify is enabled.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 7, 2023
Copy link

stackblitz bot commented Dec 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 3e42611 into main Dec 7, 2023
10 checks passed
@patak-dev patak-dev deleted the terser-no-minify branch December 7, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WARN] [vite] build.terserOptions -- annoying false warning duiring project build
2 participants