fix: htmlFallbackMiddleware for favicon

[patak-dev]

Description

A favicon.ico request is returning the index.html because it has */* in its header. It seems that checking against image/ should work.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[bluwy]

I think it was intentional that the html fallback also apply to images, especially when we removed the dot rule. Perhaps we could special case for favicon.ico only? cc @sapphi-red

[sapphi-red]

Yeah, if */* is included, we have to treat the same with text/html. I think a special case for favicon.ico makes sense. We already have a similar check here.

vite/packages/vite/src/node/server/middlewares/transform.ts

Line 45 in 921ca41

const knownIgnoreList = new Set(['/', '/favicon.ico'])

[patak-dev]

Thanks! Updated to directly avoid the default /favicon.ico request.