Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing warmupRequest in transformIndexHtml #15303

Merged
merged 3 commits into from Dec 11, 2023

Conversation

patak-dev
Copy link
Member

Description

We missed a branch to warmup when processing the HTML files. --open didn't trigger the static imports pre-warmup in https://github.com/sapphi-red/performance-compare


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

stackblitz bot commented Dec 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the performance Performance related enhancement label Dec 10, 2023
@patak-dev
Copy link
Member Author

I don't know why the HMR and CSS tests are failing, making this one a draft for now 🤔

@patak-dev patak-dev marked this pull request as draft December 10, 2023 17:09
@patak-dev patak-dev marked this pull request as ready for review December 10, 2023 19:27
@patak-dev
Copy link
Member Author

Ok, got it now

@patak-dev
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on c244380: Open

suite result latest scheduled
analogjs success success
astro success success
histoire success success
ladle success success
laravel failure failure
marko success success
nuxt failure failure
nx success success
previewjs success success
qwik success success
rakkas success success
sveltekit success success
unocss success success
vike success success
vite-plugin-pwa success success
vite-plugin-react success success
vite-plugin-react-pages success success
vite-plugin-react-swc success success
vite-plugin-svelte success success
vite-plugin-vue success success
vite-setup-catalogue success success
vitepress success success
vitest success success

@patak-dev patak-dev merged commit 103820f into main Dec 11, 2023
15 checks passed
@patak-dev patak-dev deleted the fix/missing-pretransform-request branch December 11, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants