fix: more stable hash calculation for depsOptimize #15337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patak-dev
reviewed
Dec 13, 2023
| include: optimizeDeps?.include, | ||
| exclude: optimizeDeps?.exclude, | ||
| include: Array.from(new Set(optimizeDeps?.include)).sort(), | ||
| exclude: Array.from(new Set(optimizeDeps?.exclude)).sort(), |
There was a problem hiding this comment.
Nice one! Sounds good to me. We should still keep it as undefined if the option wasnt set though to avoid changing the hash for all the projects without explicit include/exclude and trigger a cold start for them
patak-dev
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Plugins could contribute to that list by simply pushing new items. While the order of them and duplicated items do not affect how deps works. We do a unique and sort, to make the hash calculation more stable.
Additional context
related: nuxt/nuxt#24196 (comment)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).