Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize literal-only entry pattern #16010

Merged
merged 1 commit into from Feb 28, 2024

Conversation

btea
Copy link
Collaborator

@btea btea commented Feb 22, 2024

Description

After merging #15853, custom optimizeDeps.entries may skip running fast-glob. In order to keep the custom optimizeDeps.entries result in the same format as the result returned by fast-glob on the windows platform, normalizePath is called to process the path.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Feb 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand why this is needed, but it's nice if you can leave a PR description of the change in the future 👍

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 28, 2024
@bluwy bluwy merged commit 1dccc37 into vitejs:main Feb 28, 2024
10 checks passed
@btea btea deleted the fix/normalize-literal-only-entries branch February 28, 2024 10:09
@btea
Copy link
Collaborator Author

btea commented Feb 28, 2024

@bluwy Do you mean to update the description of entries in the documentation?

@bluwy
Copy link
Member

bluwy commented Feb 28, 2024

No, I meant the description in this PR, eg explaining what this PR does and why it's needed. Currently it's a blank template.

@btea
Copy link
Collaborator Author

btea commented Feb 28, 2024

Oh, I see, I'll add it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants