Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfork @polka/compression #16118

Closed
4 tasks done
benmccann opened this issue Mar 7, 2024 · 0 comments · Fixed by #16146
Closed
4 tasks done

Unfork @polka/compression #16118

benmccann opened this issue Mar 7, 2024 · 0 comments · Fixed by #16146
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@benmccann
Copy link
Collaborator

benmccann commented Mar 7, 2024

Description

https://github.com/vitejs/vite/blob/main/packages/vite/src/node/server/middlewares/compression.ts is a copy of the code contained in lukeed/polka#148, which hadn't been merged and released yet. Now that it's available on npm, it'd be nice to use that package. It'd be great for the ecosystem to use the same published package so that we can share bug fixes. I'm sending a PR to use it in SvelteKit as well (sveltejs/kit#11952)

Suggested solution

https://www.npmjs.com/package/@polka/compression

Alternative

No response

Additional context

No response

Validations

@bluwy bluwy added enhancement New feature or request good first issue Good for newcomers and removed enhancement: pending triage labels Mar 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants